Note to self: when creating XPIs for Firefox extensions, make sure that you create the achive properly. The install.rdf and chrome directory must be in the root of the archive - I was repeatedly making an archive which was /myextension/install.rdf.
DOH.
This web tool makes the creation of install.rdf a doddle too, I suggest you try it out.